Re: [ros-dev] [ros-diffs] [ion] 57284: [NTOSKRNL]: Use the token lock acquire/release macros that were already written instead of manually doing it. Also fix the macros since they didn't work in GCC. No functional change, j...

Wed, 12 Sep 2012 09:39:05 -0700 

Why the removal of the do/while loop?
This breaks the macro when used without braces :

+#define SepReleaseTokenLock(Token)                                             
\
+    ExReleaseResource(((PTOKEN)Token)->TokenLock);                             
\
+    KeLeaveCriticalRegion();                                                   
\
+

<snip>

-#define SepReleaseTokenLock(Token)                                             
\
-  do {                                                                         
\
-    ExReleaseResource(((PTOKEN)Token)->TokenLock);                             
\
-    KeLeaveCriticalRegion();                                                   
\
-  while(0)

<snip>

     /* Release the lock if we had acquired it */
+    if (!TokenLocked) SepReleaseTokenLock(Token);
 



_______________________________________________
Ros-dev mailing list
[email protected]
http://www.reactos.org/mailman/listinfo/ros-dev

Reply via email to