IMHO he just kept the original code : see http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/syssetup/wizard.c ?r1=58960&r2=58959&pathrev=58960 You can discover the real culprit here : http://svn.reactos.org/svn/reactos?view=revision&revision=21249 (6 years ago) :D
Cheers, Hermès -----Message d'origine----- De : [email protected] [mailto:[email protected]] De la part de Jérôme Gardou Envoyé : lundi 6 mai 2013 17:49 À : [email protected] Objet : Re: [ros-dev] [ros-diffs] [pschweitzer] 58960: [RTL] Finally reenable RtlAcquirePrivilege Hey Pierre! Nice patch series, that takes ReactOS nearer to being secure. A remark though : > /* > - * enable the SeSystemtimePrivilege privilege > + * Call SetLocalTime twice to ensure correct results > */ > + Ret = SetLocalTime(&SetupData->SystemTime) && > + SetLocalTime(&SetupData->SystemTime); This is a bit confusing, and the comment doesn't really help. Why would calling the function twice ansure correct result ? Also, this is likely to be optimized away by the compiler, or at least produce a report in static code analysers. I know this isn't pure chance. Any hint as to why you wrote it like this ? Cheers Jérôme _______________________________________________ Ros-dev mailing list [email protected] http://www.reactos.org/mailman/listinfo/ros-dev _______________________________________________ Ros-dev mailing list [email protected] http://www.reactos.org/mailman/listinfo/ros-dev
