Jim, this and your other patch can never happen. It's ListEntry that can be NULL, but Property will never be (in fact, it will be negative number). Also, ListEntry should never be NULL anyway, otherwise it means the list head is corrupted.
Containing record is just math...not a dereference. -- Best regards, Alex Ionescu -----Original Message----- From: [email protected] [mailto:[email protected]] On Behalf Of [email protected] Sent: Tuesday, October 15, 2013 3:17 PM To: [email protected] Subject: [ros-diffs] [jimtabor] 60683: [Win32ss] - Prevent a potential kernel exception. Author: jimtabor Date: Tue Oct 15 22:16:31 2013 New Revision: 60683 URL: http://svn.reactos.org/svn/reactos?rev=60683&view=rev Log: [Win32ss] - Prevent a potential kernel exception. Modified: trunk/reactos/win32ss/user/ntuser/prop.c Modified: trunk/reactos/win32ss/user/ntuser/prop.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/prop.c?rev=60683&r1=60682&r2=60683&view=diff ============================================================================== --- trunk/reactos/win32ss/user/ntuser/prop.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/ntuser/prop.c [iso-8859-1] Tue Oct 15 22:16:31 2013 @@ -21,6 +21,7 @@ while (ListEntry != &Window->PropListHead) { Property = CONTAINING_RECORD(ListEntry, PROPERTY, PropListEntry); + if (!Property) break; if (Property->Atom == Atom) { return(Property); _______________________________________________ Ros-dev mailing list [email protected] http://www.reactos.org/mailman/listinfo/ros-dev
