> Honestly, I don't see any point in these modifications. The next time someone > wants to use these debug routines, he will need to add it back. Or he will > start using DPRINT stuff again. I'd prefer to have this in all files!
Clang emits warnings because of them, and having includes that we don't use doesn't make sense (we can also use this argument to include unneeded headers right now simply because we may need them in the future). There are tools to perform the exact opposite pattern (http://code.google.com/p/include-what-you-use/ https://code.google.com/p/uninclude/ and co) Please note that these inclusions are being removed in *most* of our codebase through Wine (http://source.winehq.org/git/wine.git/?a=search&h=HEAD&st=commit&s=%28Clang%29) When someone revisits this code and needs to add debug routines, then he'll simply have to include the relevant header. If he starts using DPRINT stuff *then* you may issue an email advising *him* not to. _______________________________________________ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
