Did you check the existing tests ? Many of them are run during test runs. Kind
regards, Sylvain Petreolle
Le Samedi 24 septembre 2016 17h28, Christoph von Wittich
<christ...@apiviewer.de> a écrit :
I guess CreateFile in wine doesn't return the correct LastError when you pass
an invalid path like "C:C:\Windows"
Our CreateFile returns ERROR_INVALID_NAME, wines PATH_NOT_FOUND or
FILE_NOT_FOUND
Guess we need a test for CreateFile...
Am 24.09.2016 um 17:10 schrieb Thomas Faber:
What's the symptom you're trying to fix?
Is it a problem for Wine also, or just for us? And why?
Trying to understand why we need to break Wine sync here.
On 2016-09-24 17:01, Christoph von Wittich wrote:
It won't work for absolute paths as it will result in C:C:\folder\. I
committed a better fix.
Am 24.09.2016 um 13:56 schrieb Thomas Faber:
Could you elaborate on what makes it broken? Link to a bug perhaps?
On 2016-09-24 13:39, cwitt...@svn.reactos.org wrote:
Author: cwittich
Date: Sat Sep 24 11:39:17 2016
New Revision: 72792
URL: http://svn.reactos.org/svn/reactos?rev=72792&view=rev
Log:
[CRYPTNET] disable broken code
Modified:
trunk/reactos/dll/win32/cryptnet/cryptnet_main.c
Modified: trunk/reactos/dll/win32/cryptnet/cryptnet_main.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/cryptnet/cryptnet_main.c?rev=72792&r1=72791&r2=72792&view=diff
==============================================================================
--- trunk/reactos/dll/win32/cryptnet/cryptnet_main.c [iso-8859-1] (original)
+++ trunk/reactos/dll/win32/cryptnet/cryptnet_main.c [iso-8859-1] Sat Sep 24
11:39:17 2016
@@ -1025,6 +1025,7 @@
components.dwUrlPathLength + 1);
hFile = CreateFileW(path, GENERIC_READ, FILE_SHARE_READ,
NULL, OPEN_EXISTING, FILE_ATTRIBUTE_NORMAL, NULL);
+#ifndef __REACTOS__
if (hFile == INVALID_HANDLE_VALUE)
{
/* Try again on the current drive */
@@ -1049,6 +1050,7 @@
}
}
}
+#endif
if (hFile != INVALID_HANDLE_VALUE)
{
if ((ret = CRYPT_GetObjectFromFile(hFile, pObject)))
_______________________________________________
Ros-dev mailing list
Ros-dev@reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev
_______________________________________________
Ros-dev mailing list
Ros-dev@reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev
_______________________________________________
Ros-dev mailing list
Ros-dev@reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev
