On 2017-03-12 10:48, gadamopou...@svn.reactos.org wrote:
// *** IServiceProvider methods ***
HRESULT STDMETHODCALLTYPE CExplorerBand::QueryService(REFGUID guidService,
REFIID riid, void **ppvObject)
{
- UNIMPLEMENTED;
- return E_NOTIMPL;
+ /* FIXME: we probably want to handle more services here */
+ return IUnknown_QueryService(pSite, SID_SShellBrowser, riid, ppvObject);
}
This seems dangerous. If someone requests something other than
SID_SShellBrowser, we'll just return them a different object without
any indication that something is wrong.
Shouldn't we either pass guidService down or fail somehow if it's not
asking for ShellBrowser?
_______________________________________________
Ros-dev mailing list
Ros-dev@reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev
