On 2017-05-13 18:13, hbelu...@svn.reactos.org wrote:
--- branches/setup_improvements/base/setup/usetup/filesup.c     [iso-8859-1] 
(original)
+++ branches/setup_improvements/base/setup/usetup/filesup.c     [iso-8859-1] 
Sat May 13 16:13:49 2017

@@ -524,14 +523,10 @@
                         &IoStatusBlock,
                         0,
                         FILE_SYNCHRONOUS_IO_NONALERT);
-    if (!NT_SUCCESS(Status))
-    {
-      return FALSE;
-    }

     NtClose(FileHandle);

-    return TRUE;
+    return NT_SUCCESS(Status);
 }

Not an improvement. You're now closing an uninitialized handle on
failure.


_______________________________________________
Ros-dev mailing list
Ros-dev@reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev

Reply via email to