I'd like to expand on point 2, which is something myself and DavidQ were discussing recently. Our PRs are becoming out of control. I've been though a lot of the top project on github, and most seem to have just a small handful of open PRs at any one time. As of this writing, we're currently at 83 and we've consistently increased since we first moved to github. We're on track to surpass 100 next month.
Potential problems are: 1) we have too few people reviewing 2) some of the devs reviewing are far too picky/pedantic in their comments 3) people are too afraid of just merging them 4) anything not on the first page gets ignored 4) something else? My personal thoughts are we have a mixture of 2 & 3, with a hint of 4. Whatever the issues are, there are certainly things we can do to address it, but I'll leave that for the meeting discussion. Ged. -----Original Message----- From: Ros-dev <ros-dev-boun...@reactos.org> On Behalf Of Colin Finck Sent: Monday, 28 May 2018 08:16 To: 'ReactOS Development List' <ros-dev@reactos.org> Subject: [ros-dev] Status Meeting (May 2018) Hi all! Let me invite you to the May 2018 meeting, taking place this Thursday, May 31, 2018 at 19:00 UTC. Invited members will again receive their credentials shortly before the meeting. Based on requests and current topics, the agenda looks like this: 1. Status Reports ============== Like last time, participants are requested to just post their prepared reports again to not waste any minute. 2. Improving our handling of PRs and JIRA reports ============================================== The global JIRA permissions have been changed this month and there has been a lot of bad blood regarding issues marked as "trivial". On the one hand, trivial PRs waste a lot of time of our core developers as long as they are the only ones able to commit them. On the other hand, trivial PRs still add minor improvements to the code, so it would be wrong to just close them as invalid. Let's have an open discussion on this topic and try to establish rules we can all work with without taking this problem to a personal level. 3. Google Summer of Code ===================== This will be the first meeting, which could be joined by our GSoC student Victor Perevertkin. If he or the mentors have questions that are better discussed with all developers in the monthly meeting, let's do this here. 4. Changes affecting base addresses ================================ Robert Naumann has requested adding this topic to the agenda. He couldn't merge several PRs translating .mc files, because that would blow up the kernel and require a regeneration of all base addresses. He requested a brainstorming session in this meeting to get to a conclusion how to deal with this problem. I know that Joachim Henze has also attempted to change base addresses lately to fix Photoshop CS2, so this is probably the right time to deal with this problem. Further topics can be requested by replying to this mail. See you all on Thursday! Best regards, Colin _______________________________________________ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
