Author: tfaber Date: Mon Aug 10 14:28:50 2015 New Revision: 68667 URL: http://svn.reactos.org/svn/reactos?rev=68667&view=rev Log: [SETUPAPI] - Always initialize file_op::dst_sd so we don't free an uninitialized pointer. CORE-10004 #resolve
Modified: trunk/reactos/dll/win32/setupapi/queue.c Modified: trunk/reactos/dll/win32/setupapi/queue.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/setupapi/queue.c?rev=68667&r1=68666&r2=68667&view=diff ============================================================================== --- trunk/reactos/dll/win32/setupapi/queue.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/setupapi/queue.c [iso-8859-1] Mon Aug 10 14:28:50 2015 @@ -459,6 +459,7 @@ op->src_tag = strdupAtoW( params->SourceTagfile ); op->dst_path = strdupAtoW( params->TargetDirectory ); op->dst_file = strdupAtoW( params->TargetFilename ); + op->dst_sd = NULL; /* some defaults */ if (!op->src_file) op->src_file = op->dst_file; @@ -632,6 +633,7 @@ op->src_tag = NULL; op->dst_path = strdupAtoW( part1 ); op->dst_file = strdupAtoW( part2 ); + op->dst_sd = NULL; queue_file_op( &queue->delete_queue, op ); return TRUE; } @@ -654,6 +656,7 @@ op->src_tag = NULL; op->dst_path = strdupW( part1 ); op->dst_file = strdupW( part2 ); + op->dst_sd = NULL; queue_file_op( &queue->delete_queue, op ); return TRUE; } @@ -677,6 +680,7 @@ op->src_tag = NULL; op->dst_path = strdupAtoW( TargetPath ); op->dst_file = strdupAtoW( TargetFilename ); + op->dst_sd = NULL; queue_file_op( &queue->rename_queue, op ); return TRUE; } @@ -700,6 +704,7 @@ op->src_tag = NULL; op->dst_path = strdupW( TargetPath ); op->dst_file = strdupW( TargetFilename ); + op->dst_sd = NULL; queue_file_op( &queue->rename_queue, op ); return TRUE; }