[ros-diffs] [reactos] 01/01: [NTOSKRNL] Don't dereference VACB when allocating its memory area fails

[Pierre Schweitzer]

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=182cc5c5ab027790276c1c06c587d7b9057612a0

commit 182cc5c5ab027790276c1c06c587d7b9057612a0
Author:     Pierre Schweitzer <pie...@reactos.org>
AuthorDate: Sat Dec 8 19:51:30 2018 +0100
Commit:     Pierre Schweitzer <pie...@reactos.org>
CommitDate: Sat Dec 8 19:56:03 2018 +0100

    [NTOSKRNL] Don't dereference VACB when allocating its memory area fails
    
    This avoids performing a double-free (even though that's hidden by the
    fact we use lookaside allocations for VACB), and it avoids freeing
    a memory address at an uninitialized address.
    We don't care about references here, the VACB was just allocated, never
    linked and we're its only user.
    
    CORE-15413
---
 ntoskrnl/cc/view.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/ntoskrnl/cc/view.c b/ntoskrnl/cc/view.c
index b9c4930986..d7dcfe1ff7 100644
--- a/ntoskrnl/cc/view.c
+++ b/ntoskrnl/cc/view.c
@@ -833,7 +833,6 @@ Retry:
             goto Retry;
         }
 
-        CcRosVacbDecRefCount(current);
         ExFreeToNPagedLookasideList(&VacbLookasideList, current);
         return Status;
     }