https://git.reactos.org/?p=reactos.git;a=commitdiff;h=801ec51a91c3af778d88d8f9446eee0cb1d8e943

commit 801ec51a91c3af778d88d8f9446eee0cb1d8e943
Author:     Timo Kreuzer <[email protected]>
AuthorDate: Sun Apr 28 20:30:18 2019 +0200
Commit:     HervĂ© Poussineau <[email protected]>
CommitDate: Mon May 27 13:22:40 2019 +0200

    [BROWSEUI] Fix indentation
    
    Fixes GCC 8 warning:
    dll/win32/browseui/explorerband.cpp:1332:17: error: this 'if' clause does 
not guard... [-Werror=misleading-indentation]
                     if (!SUCCEEDED(hr) || !pParent.p)
                     ^~
    dll/win32/browseui/explorerband.cpp:1335:21: note: ...this statement, but 
the latter is misleadingly indented as if it were guarded by the 'if'
                         hr = pParent->SetNameOf(0, pidlChild, 
dispInfo->item.pszText, SHGDN_INFOLDER, &pidlNew);
                         ^~
---
 dll/win32/browseui/explorerband.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/dll/win32/browseui/explorerband.cpp 
b/dll/win32/browseui/explorerband.cpp
index 968b173ec3..741960c1d1 100644
--- a/dll/win32/browseui/explorerband.cpp
+++ b/dll/win32/browseui/explorerband.cpp
@@ -1329,8 +1329,8 @@ HRESULT STDMETHODCALLTYPE CExplorerBand::OnWinEvent(HWND 
hWnd, UINT uMsg, WPARAM
                     LPCITEMIDLIST pidlChild;
 
                     hr = SHBindToParent(info->absolutePidl, 
IID_PPV_ARG(IShellFolder, &pParent), &pidlChild);
-                if (!SUCCEEDED(hr) || !pParent.p)
-                    return E_FAIL;
+                    if (!SUCCEEDED(hr) || !pParent.p)
+                        return E_FAIL;
 
                     hr = pParent->SetNameOf(0, pidlChild, 
dispInfo->item.pszText, SHGDN_INFOLDER, &pidlNew);
                     if(SUCCEEDED(hr) && pidlNew)

Reply via email to