[ros-diffs] [reactos] 01/01: [SHELL32] Do not reopen the drive properties dialog on cancel (#4383)

[Mark Jansen]

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=af33607a273f46e704d66e92eaf09799d3a5834f

commit af33607a273f46e704d66e92eaf09799d3a5834f
Author:     Mark Jansen <mark.jan...@reactos.org>
AuthorDate: Sat Mar 12 15:25:48 2022 +0100
Commit:     GitHub <nore...@github.com>
CommitDate: Sat Mar 12 15:25:48 2022 +0100

    [SHELL32] Do not reopen the drive properties dialog on cancel (#4383)
    
    CORE-18073
---
 dll/win32/shell32/dialogs/drive.cpp | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/dll/win32/shell32/dialogs/drive.cpp 
b/dll/win32/shell32/dialogs/drive.cpp
index be1c8c8b109..8f2484e298a 100644
--- a/dll/win32/shell32/dialogs/drive.cpp
+++ b/dll/win32/shell32/dialogs/drive.cpp
@@ -226,10 +226,8 @@ SH_ShowDriveProperties(WCHAR *pwszDrive, LPCITEMIDLIST 
pidlFolder, PCUITEMID_CHI
     if (pDrvDefExt)
         pDrvDefExt->Release();
 
-    if (ret > 0)
+    if (ret >= 0)
         return S_OK;
-    if (ret == 0)
-        return S_FALSE;
     return E_FAIL;
 }