https://git.reactos.org/?p=reactos.git;a=commitdiff;h=be64b5c843d955566a1919fd3012d8c9845e1dce

commit be64b5c843d955566a1919fd3012d8c9845e1dce
Author:     winesync <[email protected]>
AuthorDate: Sun Mar 13 19:05:09 2022 +0100
Commit:     Mark Jansen <[email protected]>
CommitDate: Sun Mar 20 19:28:26 2022 +0100

    [WINESYNC] msi/tests: Fix a crash on Windows 10.
    
    Signed-off-by: Zebediah Figura <[email protected]>
    Signed-off-by: Hans Leidekker <[email protected]>
    Signed-off-by: Alexandre Julliard <[email protected]>
    
    wine commit id 4661c8d45b8f4b4b2adfb157bb16ce3466bc00f0 by Zebediah Figura 
<[email protected]>
---
 modules/rostests/winetests/msi/install.c | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/modules/rostests/winetests/msi/install.c 
b/modules/rostests/winetests/msi/install.c
index 0bd82a621fc..f7fd83cfc08 100644
--- a/modules/rostests/winetests/msi/install.c
+++ b/modules/rostests/winetests/msi/install.c
@@ -2744,15 +2744,14 @@ static void test_MsiInstallProduct(void)
 
     MsiSetInternalUI(INSTALLUILEVEL_NONE, NULL);
 
-    /* szPackagePath is NULL */
-    r = MsiInstallProductA(NULL, "INSTALL=ALL");
-    ok(r == ERROR_INVALID_PARAMETER,
-       "Expected ERROR_INVALID_PARAMETER, got %d\n", r);
-
-    /* both szPackagePath and szCommandLine are NULL */
-    r = MsiInstallProductA(NULL, NULL);
-    ok(r == ERROR_INVALID_PARAMETER,
-       "Expected ERROR_INVALID_PARAMETER, got %d\n", r);
+    if (0) /* crashes on Win10 1709 */
+    {
+        r = MsiInstallProductA(NULL, "INSTALL=ALL");
+        ok(r == ERROR_INVALID_PARAMETER, "got %u\n", r);
+
+        r = MsiInstallProductA(NULL, NULL);
+        ok(r == ERROR_INVALID_PARAMETER, "got %u\n", r);
+    }
 
     /* szPackagePath is empty */
     r = MsiInstallProductA("", "INSTALL=ALL");

Reply via email to