On 3/1/06 10:44 PM, Ron Savage wrote: > Pursuant to my attempts to generate Perl code under Oracle, I had to make a > number of patches to this module.
Ah, I didn't know you were editing Rose::DB::Object modules yet. I'll add them to the Oracle branch. Having just taken a casual look at your changes, I think you just broke some or all of the other dbs :) For each Oracle-specific thing that you need to do in any "shared" module, you have two choices. You can create a private Rose::DB method to make each decision (e.g., column_info_uses_uc_table_name() or something) and then make sure that only Rose::DB::Oracle overrides it in such a way that it alters the existing behavior. The second choice is to create an Oracle-specific Metadata::Auto subclass: Rose::DB::Object::Metadata::Auto::Oracle and put all your Oracle-specific code in there. That way you can be sure you aren't altering any existing behavior for other drivers. -John ------------------------------------------------------- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642 _______________________________________________ Rose-db-object mailing list Rose-db-object@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/rose-db-object