On 8/4/06 7:48 PM, Perrin Harkins wrote: > Here's a patch that fixes a problem with how IN queries are handled when > bind values are not used. It was flattening scalar refs into strings > rather than de-referencing them, but only when binds are off.
Applied, thanks. > Couldn't figure out where this should go in the test suite, but if you > point me at something that does it for the binds I could try writing a > test for it. QueryBuilder is exercised indirectly by the many Manager tests, but there aren't really any tests dedicated to the use of QueryBuilder in isolation. I've added a new test file for that purpose (t/query-builder.t) but I only put in one simple test to confirm the bug fix you just sent. If you have some more QueryBuilder examples from your own code, feel free to add them as tests and send me another patch :) -John ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Rose-db-object mailing list Rose-db-object@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/rose-db-object
