On 10/25/06 1:14 AM, Jonathan Vanasco wrote:
> I noticed that YAML::Syck / JSON::Syck can sometimes have a blank
> line in it, which can screw the parser up, and then the rose reader
> 
> This will fix it:
> 
> next unless $column;

How about...

    next  unless(length $column);

You know, to let columns named "0" through :)

> what about consolidating both functions a bit, and adding
> 'init_with_hashref' ?
> 
> i say this because:
> a- i'm using an init_with_hashref already
> b- init_with_yaml / init_with_json have 80% of the same
> functionality.  we could save some memory here.

...and incur one more method call, of course.  I'm inclined to take the
memory hit :)  Also, init_with_hashref is a  pretty vague name.  Hash of
what?  Maybe init_with_column_values_hashref or something, but that starts
to get kind of long.

-John



-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Rose-db-object mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/rose-db-object

Reply via email to