On Thu, 17, Jul, 2003 at 02:13:28PM +0100, Richard Bown spoke thus..
> You need to UpdateRefreshStatuses - comes for free if you implement Commands
> to correctly to apply the colour changes.

Right.

I've been looking at this but can't decide which is the better way of
doing it.

BasicCommand only takes a single Segment and I want the method to
present a single colour change to a number of selected segments as one
undo Item (which is logical).  There is BasicSelectionCommand but that's
for EventSelections not SegmentSelections (yes, I'm aware at present
SegmentSelections is little more than a glorified typedef).

The basic functionality is easy - I simply do the same thing as
SegmentLabelCommand and derive from KNamedCommand but this doesn't
provide the UpdateRefreshStatuses for free.

Now, should I:
1) Implement the updateRefreshStatuses within the SegmentColourCommand

or

2) Take the time to create a class similar to BasicCommand and
BasicSelectionCommand (maybe BasicSegmentCommand) which can deal with
a Rosegarden::SegmentSelection so that if we need to do something like
this in future, the framework is already there.

Mark


-- 
Mark Hymers <markh at linuxfromscratch dot org>

"Don't you hate those Claims Direct adverts?
 'I slipped on a banana skin and sued the Dominican Republic!'"
     Linda Smith on the News Quiz talking about the Compensation Culture


-------------------------------------------------------
This SF.net email is sponsored by: VM Ware
With VMware you can run multiple operating systems on a single machine.
WITHOUT REBOOTING! Mix Linux / Windows / Novell virtual machines at the
same time. Free trial click here: http://www.vmware.com/wl/offer/345/0
_______________________________________________
Rosegarden-devel mailing list
[EMAIL PROTECTED] - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel

Reply via email to