Composition::weakAddSegment adds a segment but doesn't update the 
refresh statuses or call notifySegmentAdded.  It was introduced on the 
experimental branch "to avoid needlessly signaling about detached 
segments which are about to be re-added", but most of the uses of it 
were later turned into calls to setSegmentStartTime.

It's now used in exactly one place: Segment::setTrack.  But isn't that 
actually a place where we _do_ want to update the refresh statuses?  
That looks like the cause of this bug:

https://sourceforge.net/tracker/?func=detail&aid=778332&group_id=4932&atid=104932

and possibly some problems with instruments not changing properly when a 
track changes during playback in the mmapped scheme?

Is there another reason we might want to continue using this here?  Or 
what should we best do instead?


Chris



-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
_______________________________________________
Rosegarden-devel mailing list
[EMAIL PROTECTED] - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel

Reply via email to