On Sunday 02 Nov 2003 12:31 pm, Chris Cannam wrote:
> On Sunday 02 Nov 2003 11:54 am, Daniel MacDonald wrote:
> > Even worse, and I'm SURE you're well aware of this un
> > as it's been plagueing CVS for the last couple of
> > weeks, opening the matrix editor and inserting a note
> > instantly bombs RG, producing this spiel [...]
>
> Ouch!

OK, this is fixed in CVS.  The problem was excessive inheritance: the 
chord name ruler was calling Segment::clear(), but Segment didn't 
actually implement clear(), it was just inheriting it from multiset, 
whose clear() was of course not calling any of the various callbacks 
that need to be activated when something is removed from a Segment.

Dan just posted with the quick fix I tested, but the one I actually 
committed was to leave the call to clear() in place and implement it 
in Segment by simply calling erase(begin(), end()).  That way nobody 
else gets to make the same mistake again.


Chris



-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive?  Does it
help you create better code?   SHARE THE LOVE, and help us help
YOU!  Click Here: http://sourceforge.net/donate/
_______________________________________________
Rosegarden-devel mailing list
[EMAIL PROTECTED] - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel

Reply via email to