On Sunday 13 Feb 2005 15:10, Pedro Lopez-Cabanillas wrote: > We should restore the locale after enumerating plugins. I will write, test > and commit a fix about this, unless you do it before.
Yes, please do. Of course any plugin function could call setlocale, not just _init. We probably ought to reset the locale after calling certain other functions as well, in the sequencer. Don't worry about that for now though. > Another question: I have been testing this issue without Jack being active, > so no audio capabilities where enabled in RG. Shouldn't be disabled this > plugin enumeration when RG has not audio caps enabled? But then we wouldn't have found this bug, would we? You're probably right, in principle. There are two alternative positions -- either we should do everything just the same whether audio is present or not (so that you can load a file, edit the non-audio bits, and save it again without losing existing audio data from the file just because there was no audio support present when it was edited) or we should avoid doing any audio work at all when audio is not present (so as to save time). We actually have a grisly hybrid at the moment -- we still enumerate plugins etc, but we have no audio instruments, so we still can't load, edit and save a file without disrupting its audio data. However, I don't suggest we change that just before the release. Chris ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ Rosegarden-devel mailing list [email protected] - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
