I agree with compiling without pchs before committing, but changing the includes depending on whether the compile uses PCH or not just doesn't make any sense to me. What's the rationale behind the USE_PCH flag ?
On Friday 26 October 2007, [EMAIL PROTECTED] wrote: > Revision: 8375 > > http://rosegarden.svn.sourceforge.net/rosegarden/?rev=8375&view=rev Author: > plcl > Date: 2007-10-26 08:13:35 -0700 (Fri, 26 Oct 2007) > > Log Message: > ----------- > Please, developers: remember to build without using precompiled headers > before committing new code. Thanks. > > Modified Paths: > -------------- > trunk/rosegarden/CMakeLists.txt > trunk/rosegarden/src/gui/application/main.cpp > > Modified: trunk/rosegarden/CMakeLists.txt > =================================================================== > --- trunk/rosegarden/CMakeLists.txt 2007-10-24 21:59:08 UTC (rev 8374) > +++ trunk/rosegarden/CMakeLists.txt 2007-10-26 15:13:35 UTC (rev 8375) > @@ -256,6 +256,7 @@ > FIND_PACKAGE(PCHSupport) > IF(PCHSupport_FOUND) > SET(USE_PCH TRUE) > + ADD_DEFINITIONS(-DUSE_PCH) > MESSAGE(STATUS "Enabling precompiled headers for GCC > ${gcc_compiler_version}") ENDIF(PCHSupport_FOUND) > ENDIF(WANT_PCH) > > Modified: trunk/rosegarden/src/gui/application/main.cpp > =================================================================== > --- trunk/rosegarden/src/gui/application/main.cpp 2007-10-24 21:59:08 UTC > (rev 8374) +++ trunk/rosegarden/src/gui/application/main.cpp 2007-10-26 > 15:13:35 UTC (rev 8375) @@ -19,11 +19,13 @@ > COPYING included with this distribution for more information. > */ > > +#ifndef USE_PCH > +#include <sys/time.h> > +#include <qlabel.h> > #include <qtimer.h> > +#include <qstringlist.h> > +#include <qregexp.h> > #include <kapplication.h> > -#include <sys/time.h> > -#include "base/RealTime.h" > - > #include <kcmdlineargs.h> > #include <kaboutdata.h> > #include <klocale.h> > @@ -34,21 +36,18 @@ > #include <ktip.h> > #include <kprocess.h> > #include <kglobalsettings.h> > +#endif -- Guillaume. http://telegraph-road.org ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Rosegarden-devel mailing list [email protected] - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
