On Mon, Sep 8, 2008 at 2:21 AM, Julie S <[EMAIL PROTECTED]> wrote:
> Me too.  I know I added #include <Q3Canvas>, but you did that manually.  
> Possibly, Chris scrubbed the script first before he ran it or he used an 
> outdated script.  These are just guesses though and at this point is pretty 
> pointless to speculate.

It's not _that_ pointless to speculate -- the scripted conversion was
committed as a single Subversion revision (rev 9075) in the qt4
branch, so you can easily see whether any given file was modified by
it and how:

$ svn diff -r9074:9075 src/gui/widgets/PitchDragLabel.cpp

In this example you'll see that a Q3CanvasPixmap header was added
automatically, but Q3Canvas was not -- it was added later on (svn
annotate tells us by Michael in rev 9127).

That's worth knowing, if only because it rules out some other cause of
the missing #include that might be worth investigating.  (If someone
might have accidentally committed a reversed patch that removed some
includes, or something like that, we would want to know about it.  If
it's just that the script didn't get it quite right, we don't have to
care.)


Chris

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Rosegarden-devel mailing list
[email protected] - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel

Reply via email to