On Tue, Jul 7, 2009 at 7:26 PM, Emanuel Rumpf<[email protected]> wrote: > I just wanted to fix the menu of MatrixView and > got that EditView is not being used anymore, > instead EditViewBase is inherited directly. > > I wonder, what to do with the actions (createAction(..)) set up in EditView. > Move them to EditViewBase - or to MatrixView ?
I think we need to avoid having such a heavyweight base class as the former EditView. It was complicated enough in the way it interacted with each subclass to make it only harder to understand the subclasses, not easier. I think in hindsight that "cut-and-paste code" is actually preferable to this. Many of the actions remaining in EditView are extremely trivial two-liners: check getSelection is non-null, issue a command using it. These I think should simply be duplicated in both NotationView and MatrixView. (One thing I forgot to mention when discussing some of the action functions for NotationView earlier is that I think there's absolutely no value in setting the status bar message while we carry out such a trivial operation -- all those TmpStatusMsg objects should go.) The insert tempo/timesig actions are a bit less clear-cut -- possibly the functions themselves are simply too complicated; where else should that work be done? Chris ------------------------------------------------------------------------------ Enter the BlackBerry Developer Challenge This is your chance to win up to $100,000 in prizes! For a limited time, vendors submitting new applications to BlackBerry App World(TM) will have the opportunity to enter the BlackBerry Developer Challenge. See full prize details at: http://p.sf.net/sfu/blackberry _______________________________________________ Rosegarden-devel mailing list [email protected] - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
