D. Michael McIntyre wrote:

If you've already ifdeffed out your copy, send me the patch, and that way it won't conflict with your working copy when I commit it.


Sorry it's taken me so long to get around to this: anyway, here's my patch to allow FileDialog.cpp to compile with Qt versions < 4.5.0.

I'd still recommend upgrading Qt for better results with Rosegarden (and hey, especially if it happens to randomly fix this crash problem I can't repeat!) but I value your presence here, Colin, and I don't want to put obstacles in your way.

I think I'll stick with the version of Qt I've got until I really have to upgrade it: in fact, if it had have happened to randomly fix the crash, I can only suppose that some other poor sucker would have eventually run into the same problem, so I suppose I'm doing somebody a favour by finding these things first...

Cheers,

Colin.

Index: src/gui/widgets/FileDialog.cpp
===================================================================
--- src/gui/widgets/FileDialog.cpp	(revision 10607)
+++ src/gui/widgets/FileDialog.cpp	(working copy)
@@ -90,8 +90,10 @@
 {
     FileDialog dialog(parent, caption, dir, filter);
 
+#if QT_VERSION >= 0x040500
     if (options)
-        dialog.setOptions(options);
+       dialog.setOptions(options);
+#endif
 
     // (code borrowed straight out of Qt 4.5.0 Copyright 2009 Nokia)
     if (selectedFilter)
@@ -117,8 +119,10 @@
 {
     FileDialog dialog(parent, caption, dir, filter);
 
+#if QT_VERSION >= 0x040500
     if (options)
         dialog.setOptions(options);
+#endif
 
     // (code borrowed straight out of Qt 4.5.0 Copyright 2009 Nokia)
     if (selectedFilter)
@@ -144,8 +148,10 @@
 {
     FileDialog dialog(parent, caption, dir, filter);
 
+#if QT_VERSION >= 0x040500
     if (options)
         dialog.setOptions(options);
+#endif
 
     // (code borrowed straight out of Qt 4.5.0 Copyright 2009 Nokia)
     dialog.setAcceptMode(QFileDialog::AcceptSave);
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Rosegarden-devel mailing list
[email protected] - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel

Reply via email to