Dear Heikki, You last commit may cause a conflict with my pending merge. Since, I've altered a lot of code in NotationView.cpp related to notes and durations.
But maybe not. Maybe we could find a more elegant way to not allow the very sort and very long notes you are trying to warn about then throwing up a message box that disrupts workflow? I just worked in notation_toolbar_2 branch to rid ourselves of the things. Sincerely, Julie S. --- On Thu, 9/3/09, [email protected] <[email protected]> wrote: > From: [email protected] <[email protected]> > Subject: [Rosegarden-bugs] SF.net SVN: rosegarden:[10809] > trunk/rosegarden/src/gui/editors/notation/ NotationView.cpp > To: [email protected] > Date: Thursday, September 3, 2009, 2:56 PM > Revision: 10809 > http://rosegarden.svn.sourceforge.net/rosegarden/?rev=10809&view=rev > Author: hjunes > Date: 2009-09-03 18:56:05 +0000 > (Thu, 03 Sep 2009) > > Log Message: > ----------- > Warn about too long and too short dotted notes. > > Modified Paths: > -------------- > > trunk/rosegarden/src/gui/editors/notation/NotationView.cpp > > Modified: > trunk/rosegarden/src/gui/editors/notation/NotationView.cpp > =================================================================== > --- > trunk/rosegarden/src/gui/editors/notation/NotationView.cpp > 2009-09-03 15:13:42 UTC (rev 10808) > +++ > trunk/rosegarden/src/gui/editors/notation/NotationView.cpp > 2009-09-03 18:56:05 UTC (rev 10809) > @@ -1893,6 +1893,14 @@ > QString > noteToolbarName; > > Note::Type noteType > = note.getNoteType(); > + if (noteType == Note::Breve) > { > + /* was sorry */ > QMessageBox::warning(this, "", tr("There is dotted version > of double whole note. Use ties for longer notes.")); > + return ; > + } > + if (noteType == > Note::Hemidemisemiquaver) { > + /* was sorry */ > QMessageBox::warning(this, "", tr("There is dotted version > of the shortest, sixty-fourth note.")); > + return ; > + } > int noteDots = > (note.getDots() ? 0 : 1); > > QString > actionName(NotationStrings::getReferenceName(Note(noteType,noteDots))); > > > This was sent by the SourceForge.net collaborative > development platform, the world's largest Open Source > development site. > > ------------------------------------------------------------------------------ > Let Crystal Reports handle the reporting - Free Crystal > Reports 2008 30-Day > trial. Simplify your report design, integration and > deployment - and focus on > what you do best, core application coding. Discover what's > new with > Crystal Reports now. http://p.sf.net/sfu/bobj-july > _______________________________________________ > Rosegarden-bugs mailing list > [email protected] > - use the link below to unsubscribe > https://lists.sourceforge.net/lists/listinfo/rosegarden-bugs > ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Rosegarden-devel mailing list [email protected] - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
