Hey

Firstly, my apologies for sending the last set of messages to the user
forum.

This patch (against trunk) does pretty much exactly what I want:

Index: src/gui/studio/MidiProgramsEditor.cpp
===================================================================
--- src/gui/studio/MidiProgramsEditor.cpp       (revision 11975)
+++ src/gui/studio/MidiProgramsEditor.cpp       (working copy)
@@ -221,11 +221,9 @@
     noKeyPixmap = il.loadPixmap("key-white");
     keyPixmap = il.loadPixmap("key-green");
 
-    bool haveKeyMappings = m_currentBank->isPercussion()
-                           && (m_device->getKeyMappings().size() > 0);
+    bool haveKeyMappings = m_device->getKeyMappings().size() > 0;
 
     for (unsigned int i = 0; i < (unsigned int)m_names.size(); i++) {

         m_names[i]->clear();
         getKeyMapButton(i)->setEnabled(haveKeyMappings);
@@ -306,10 +304,9 @@
     // Hack to force the percussion icons to switch state if needed.
     // code stole from populate.
     if (m_device) {
-        bool haveKeyMappings = m_currentBank->isPercussion()
-                               && (m_device->getKeyMappings().size() > 0);
+        bool haveKeyMappings = m_device->getKeyMappings().size() > 0;
 
         for (unsigned int i = 0; i < (unsigned int)m_names.size(); i++) {
             getKeyMapButton(i)->setEnabled(haveKeyMappings);
         }
     }

In other words, I get to assign key mappings to non-percussion banks.
And then the key names show up in the matrix view.

Anybody know what the thinking was behind excluding non-percussion banks
from key mapping?

bye
John



------------------------------------------------------------------------------
ThinkGeek and WIRED's GeekDad team up for the Ultimate 
GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the 
lucky parental unit.  See the prize list and enter to win: 
http://p.sf.net/sfu/thinkgeek-promo
_______________________________________________
Rosegarden-devel mailing list
[email protected] - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel

Reply via email to