This concerns bug #3560849 reported recently (2012-08-23) by Ted Felix:
1. Launch rg.
2. Studio > Manage Synth Plugins.
3. Configure synth plug-in #1 by selecting a plug-in from the dropdown.
4. Click on "Controls" button for #1. Controls dialog will appear.
5. Close the controls dialog.
6. Close the Manage Synth Plugins dialog.
7. Studio > Manage Synth Plugins.
8. Click on "Controls" button next to #1.
9. Crash.
I think I might have accidentally fixed this a few months ago, while
tackling a similar bug in my own copy of Rosegarden:
1. Launch rg.
2. Studio > Audio Mixer.
3. Click on any one of the plug-in buttons below the sliders.
4. Close the plug-in dialog.
5. Close the Audio Mixer dialog.
6. Studio > Audio Mixer.
7. Click on the same plug-in button as before.
8. Crash.
The problem, it seems, is in
"src/gui/application/RosegardenMainWindow.cpp." The conditional
statement at line 7551 is apparently not doing its job, so (I'm
guessing) line 7586 can refer to a parent that probably no longer
exists. I don't know how to fix this right, but my hack involves hard
coding line 7586 to refer directly to "this" rather than to "parent."
I occupy a small corner of the Rosegarden world, using only the
notation editor, along with DSSI-softsynth and LADSPA plugins.
Anything that I do to fix my own copy of Rosegarden could easily damage
some other aspect of the program, and I would never know it, because I
never go there. My understanding of Rosegarden and C++ is limited.
That's a fancy way of saying that I don't mean for the patch that I've
attached to be applied as is. I've included it only because it shows
exactly what I've done to make the problem go away. It's one of about
a dozen patches that I routinely apply to my own copy of Rosegarden
(svn_12984 currently) to make life easier.
The last part of the patch concerning
"src/gui/dialogs/AudioPluginDialog.cpp" is not directly related to this
problem but does involve the LADSPA plugins. It solves the highly
annoying problem of LADSPA-plugin controls initially displaying some
screwy default settings, instead of showing the settings previously
saved in the .rg file. It's the same problem that Holger Marzen has
mentioned a couple of times.
Tim
--- src/gui/application/RosegardenMainWindow.cpp 2012-06-05
02:32:11.000000000 -0700
+++ src/gui/application/RosegardenMainWindow.cpp 2012-06-05
02:36:23.192497000 -0700
@@ -7548,8 +7548,10 @@
int index)
{
RG_DEBUG << "RosegardenMainWindow::slotShowPluginDialog(" << parent << ",
" << instrumentId << ", " << index << ")" << endl;
- if (!parent)
- parent = this;
+///////
+// if (!parent)
+// parent = this;
+///////
int key = (index << 16) + instrumentId;
@@ -7583,7 +7585,10 @@
// Create the plugin dialog
//
AudioPluginDialog *dialog =
- new AudioPluginDialog(parent,
+///////
+// new AudioPluginDialog(parent,
+ new AudioPluginDialog(this,
+///////
m_doc->getPluginManager(),
m_pluginGUIManager,
container,
--- src/gui/dialogs/AudioPluginDialog.cpp 2012-04-01 08:58:56.000000000
-0700
+++ src/gui/dialogs/AudioPluginDialog.cpp 2012-06-05 02:36:23.193497000
-0700
@@ -487,7 +487,9 @@
// action (after the constructor)
//
if (m_generating == false) {
- inst->clearPorts();
+///////
+// inst->clearPorts();
+///////
if (inst->getIdentifier() != identifier) {
inst->clearConfiguration();
}
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Rosegarden-devel mailing list
[email protected] - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
