On 04/28/2015 06:33 AM, Tito Latini wrote:
> the temporary directory used by Rosegarden is full of these files after quit.

   Your patch looks good.  (Note: The temporary directory in question is 
/tmp.)

   The only problem that comes to my mind is that there are situations 
where there can be a huge number of these datablock files generated. 
(One per event in a sequence.)  This can take a very long while to clean 
up.  See this "if" in DataBlockRepository::clear():

if (segmentsDir.count() > 2000) {

   Deleting them on close would delay closing of rg, potentially 
confusing the user.  As it is now, it only delays opening of a document.

   Before we apply this patch, which I believe is a good idea, I'd 
recommend tracking down the situation where large numbers of datablocks 
are generated and see if there's another place where we could call 
DataBlockRepository::clear() that would prevent slowing down rg close.

Ted.

------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud 
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
Rosegarden-devel mailing list
Rosegarden-devel@lists.sourceforge.net - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel

Reply via email to