On 10/14/2015 05:43 PM, Yves Guillemot wrote: > I just discovered the same problem with error messages in LilyPondExporter. > I replaced tr() with QObject::tr() and now the translated strings are > correctly displayed.
Good catch, Yves! I couldn't believe it when you said this, so I did a test with my last build of Rosegarden, before I applied any of the updates of the past couple of days. I tried to export LilyPond to a file with spaces in the name. The dialog was in English, and it was broken too. LilyPond does not allow spaces or backslashes in filenames. Would you like to use %1 instead? %1 should have been an argument, not a literal %1. I forgot the .arg() completely. This is one more thing to go through before the release. I am really surprised I never tested translations of these error messages, and they were broken until just now. That's translation in Qt for you. It's frustrating how things will appear perfect at every stage but fail to work at runtime. This is why we have so many random translation hacks everywhere. I apparently missed a whole lot more that should have been there. -- D. Michael McIntyre ------------------------------------------------------------------------------ _______________________________________________ Rosegarden-devel mailing list Rosegarden-devel@lists.sourceforge.net - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
