On 11/21/2015 12:50 PM, David Faure wrote:
For a long time I've been annoyed at how clicking on a chord name wouldn't select it, at least not reliably. It turns out this is because QGraphicsItem was generating a (not very accurate, even) mask of the text and using that for the hit test. Changing that to a full-rect hit-test makes it much easier to select chord names. Any objections to the patch below?
I tried a worst case scenario before and after applying the patch. It improves chord selection behavior without increasing the odds of selecting something else by mistake, even when multiple elements fall within the text rect. Looks good to me, David!
While testing this, I noticed that merely selecting a long item, like a long chord string or a long slur, will MOVE the item, no matter how careful I am to click without dragging even a tiny amount. This has nothing to do with your patch. I am merely noting it while I am here.
Here's the file I used. -- D. Michael McIntyre
chord-selection-scenario.rg
Description: audio/rosegarden-composition
------------------------------------------------------------------------------
_______________________________________________ Rosegarden-devel mailing list Rosegarden-devel@lists.sourceforge.net - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
