On 05/01/2016 05:55 AM, David Faure wrote: >> + void signalTempoChanged(tempoT); >> + void signalMidiInLabel(const MappedEvent *event); >> + void signalMidiOutLabel(const MappedEvent *event); >> + void signalPlayButtonChecked(bool checked); >> + void signalRecordButtonChecked(bool checked); >> + void signalMetronomeButtonChecked(bool checked); > > On second thought, this could of course clearly be improved. > This version is pure decoupling of classes, but actual decoupling > of concepts would lead to something like > void playStatusChanged( some enum with playing, recording, whatever ) > > Or at least I could name these something like > signalPlaying, signalRecording, signalMetronomeActive? >
It seems like more work than it's worth to completely decouple the concepts, but I'm not doing the work, so that's your call. I do like signalPlaying and friends better than signalPlayButtonChecked and friends. I looked over the proposed changes, and see no problem with this approach. The patch didn't apply cleanly, so I didn't build and test. I'm basing this impression entirely on how it looks on paper, as it were. -- D. Michael McIntyre ------------------------------------------------------------------------------ Find and fix application performance issues faster with Applications Manager Applications Manager provides deep performance insights into multiple tiers of your business applications. It resolves application problems quickly and reduces your MTTR. Get your free trial! https://ad.doubleclick.net/ddm/clk/302982198;130105516;z _______________________________________________ Rosegarden-devel mailing list Rosegarden-devel@lists.sourceforge.net - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
