On 02/28/2017 07:08 PM, David Faure wrote:
> I vote for killing all this blockSignals(true) usage,

   I second this.  I've been removing every blockSignals() that I come 
across.  So, if you can get rid of it, please do.

> but the question is what
> happens then. In my quick test (start with cmdline arg, then open another
> doc), it all seems to work fine without the above code, but presumably it was
> added for a reason?

   That was so long ago....  We've restructured a lot of stuff in the 
meantime and it's entirely possible that it's safe to do away with it. 
I vaguely recall simplifying some of the code related to doc/view 
swapping, so I might have shuffled things the right way.

   I'll take a peek at the mailing lists around this time and see if I 
can find out what the test case was for the commit that introduced this.

Ted.

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Rosegarden-devel mailing list
Rosegarden-devel@lists.sourceforge.net - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel

Reply via email to