On samedi 30 mars 2019 15:57:30 CET Colin Fletcher wrote:
> On 30/03/2019 14:17, David Faure wrote:
> > On samedi 30 mars 2019 14:54:31 CET Colin Fletcher wrote:
> >> On 30/03/2019 12:09, David Faure wrote:
> >>> On samedi 30 mars 2019 13:05:13 CET Colin Fletcher wrote:
> >>>> On 30/03/2019 11:41, David Faure wrote:
> >>>>> On samedi 30 mars 2019 12:37:57 CET Colin Fletcher via
> >>>>> Rosegarden-devel
> >>>
> >>> wrote:
> >>>>>> no known conversion for argument 2 from ‘std::nullptr_t’
> >>>>>> to ‘QSharedPointer<Rosegarden::AudioPluginManager>’
> >>>>>
> >>>>> QSharedPtr only gained support for nullptr_t in Qt 5.8.
> >>>>>
> >>>>> Is your Qt version older than that?
> >>>>
> >>>> Ah, yes, debian stable here has Qt 5.7.1. That explains it: thank you!
> >>>>
> >>>> I'll be a little sad if it turns out that building Rosegarden on debian
> >>>> stable isn't possible any more, but if I'm the last one left trying to
> >>>> build it on a distro that doesn't have Qt 5.8, I'm willing to concede
> >>>> that I'm just an old stick-in-the-mud and patch it myself locally.
> >>>
> >>> Nah, just change the code to use {} instead of nullptr.
> >>
> >> For the record, here's the patch of what I've done to get it to build:
> >> feel free to apply it if anyone else is interested in keeping Qt 5.7
> >> compatibility; otherwise, don't worry about it.
> >
> > For my own curiosity: just writing {} didn't work? At least in the
> > function calls, maybe not in the assignment.>
> > Like this:
> > return {};
> >
> > or
> >
> > RosegardenDocument doc(nullptr, {}, true /*skip autoload*/, true,
> > false /*no sound*/);>
> > Then the patch is less intrusive/verbose and can be pushed, IMHO.
>
> I didn't even know you could do that! I assume it's a C++11ism.
Yep, that's called brace initialization.
And yeah now I realize it works in assignments too -- the type isn't known yet
on the right side of the '=' sign, but the (empty) std::initializer_list is
passed to the left side which then converts it correctly.
> So I've learned something new, too, which is always a bonus: thank you!
You're welcome.
> Updated patch with {} attached.
Looks good to me.
Do you have access in order to push it, or should I?
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5
_______________________________________________
Rosegarden-devel mailing list
Rosegarden-devel@lists.sourceforge.net - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
