I really like the change to allow for precompiled headers - it really reduces compile time. In the comments Ted mentions the problem with RG_MODULE_STRING. This seems to be an ordering problem. You can get the same warning by just including "Debug.h" at the start of a file which defines a RG_MODULE_STRING. The reason is the line in Debug.h: #define RG_MODULE_STRING "[generic] "
That means the real RG_MODULE_STRING definition is now a redefine. To solve this: 1. suppress the warning 2. remove the generic definition in Debug.h I prefer solution 2 - it forces the developer to define a RG_MODULE_STRING - otherwise he gets compile errors. Unfortunately the generic definition is used in a few places (don't know how many) so some existing code would have to change. Also the debug macros should then not be used in header files - Event.h does this - so some definitions would have to move from the header to the cpp file. Actually I prefer putting all definitions in the cpp file and only declarations in the header. What do you think ? _______________________________________________ Rosegarden-devel mailing list Rosegarden-devel@lists.sourceforge.net - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
