On dimanche 18 avril 2021 21:48:35 CEST Philip Leishman wrote: > Yes in that sense it does slot in. > I was looking for a way to use the existing macro - redefine RG_DEBUG to > something using qCDebug - this appears to be not so easy. > > I still think qCDebug is a good way to go. I just don't know how to do > it without changing many hundreds of lines of code in almost all files. > > Any suggestions ?
Well at the top of Composition.cpp (to stick to my example) we could add #define RG_DEBUG qCDebug(DEBUG_COMPOSITION) instead of the search/replace. That would work too. I try to avoid #define as much as possible, but in this case it makes sense, to avoid touching a massive amount of lines, and to keep the habits of the existing development team :) I would still remove all the ifdefs around RG_DEBUG, to benefit fully from the runtime enabling/disabling. But this can be done in a separate commit, later. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 _______________________________________________ Rosegarden-devel mailing list Rosegarden-devel@lists.sourceforge.net - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
