On 2/16/22 11:47 PM, David Faure wrote:
It's used to find libjack when linking to it.
But things aren't usually done this way in CMake, which is why
target_link_directories didn't exist until recently. The "right" way to use
pkgconfig is to follow it with a find_library call in order to resolve "lib
name jack in /usr/lib64" (as returned by pkgconfig) into a full path (/usr/
lib64/libjack.so) to link against.
This is done in the attached patch. I have to go see a customer now, feel free
to make a merge request with this patch if you like it.
I can include this in any merge requests I make, but at this point I'm
miles above my near-zero experience with cmake. If the change does show
up in Rosegarden's Git history as coming from me I hope its true origins
will be clear, above and beyond the disclaimers in the "COPYING"
license. Maybe better if it enters the codebase via some other path?
Not that I have any doubts about the quality of the patch. A quick web
search shows that you (M. Faure) have impeccable qualifications in this
area.
_______________________________________________
Rosegarden-devel mailing list
Rosegarden-devel@lists.sourceforge.net - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
