> a) fix it (it must be something really simple and stupid) Or complicated an interesting.
According to three random calculators I tried, -2 mod 12 is 10, which is clearly the assumption the person writing this code made. According to C++, -2 % 12 is -2. There's your problem. Now the old code from who knows how long ago actually does something. Whether what it does is good enough or not leaves much room for dispute. It really should handle note names in languages other than English. Since that was already there, I'm leaning toward just fixing it up and forgetting about the other stuff I was talking about earlier. This code never even got a fair chance for people to whine about it, since it never actually worked. At least not for Bb or Eb instruments. Random note: I had some old bug about TRANSPOSITION BUTCHERY and I was crying about the sky falling. I never could figure out what was I talking about. So here's an example: Part started life in C. Used Segment -> Convert Notation For to put it for a Bb trumpet. Used that again later on to convert the Bb part to A. It came out like G## G# G## G# G## G# and weird useless crapola like that. THAT'S what I was talking about. That transposition algorithm needs doctored up bigtime. -- D. Michael McIntyre ------------------------------------------------------------------------------ Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. ON SALE this month only -- learn more at: http://p.sf.net/sfu/learnmore_123012 _______________________________________________ Rosegarden-user mailing list [email protected] - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-user
