On 10/22/22 9:34 AM, Lorenzo Sutton wrote:
   Philip has made a number of improvements as a result of running cppcheck.  Some general regression testing would be helpful here.

How could we test this? :-)

Just do what you usually do. It's rare that these sorts of cleanup changes break things, but historically you guys catch any issues within a week or two. Which is quite impressive.

Seems to work fine. Just to make sure this is how it was previously discussed.

- Normal loop (Advanced Looping *deselected* in preferences) will loop the selected (light white) range e.g. selectable by doing SHIFT + LEFT-CLICK and drag or RIGHT-CLICK and drag, deselectable by just RIGHT-CLICKING without drag

Sounds right. Also you can right-click again to turn it back on. That's an improvement over older versions of looping.

- New Advanced Loop selected in preferences: Turn on/off by either SHIFT + LEFT-CLICK or RIGHT-CLICK on the ruler. Will loop the whole song, i.g. from start to the end of the last segment


Also sounds right. With a new document you might notice looping is off at first and the first right-click will turn it on (which does nothing) and another right-click is required to get loop all (blue) mode.

There is a quirk for which if you turn on Advanced looping in preferences, activate the looping, then turn off Advanced looping in preferences, the looping is still active (blue color) and continues to loop in advenced 'mode'. This stays on until you de-activate it with a RIGHT-CLICK.

Yeah. I'm not going to implement code for all the cases involving changing the preferences. Things will go back to the expected behavior if you right-click in the ruler.

Also it seems the two looping modes can still co-exist but if the advanced looping is on then the normal range loop can only be activated/deactivated via the transport window because now RIGHT-CLICK and SHIFT + LEFT-CLICK are 'grabbed' by the advanced looping feature.

The idea here is that "loop off" is only accessible via the transport. I'm also planning a toolbar button that mimics the transport button. The loop ruler only offers loop on or loop all. This was specifically requested in bug #1605.

Maybe as RIGHT-CLICK and SHIFT + LEFT-CLICK seem to be functionally the same if they could be differentiated.

Not sure what you are saying here. Shift+left and right are treated exactly the same in the code for historic reasons. Only right-click is documented in the tool tip.

Since Advanced Looping is a new mode, we can reassign these any way you want. The hope is that Advanced Looping will become the default for 23.06 if all goes well.

If advanced loop is on and activated (i.e. blue) I think it's confusing to see the former loop range in lighter blue, as this is not used now.

Right. The reason for this is that the range can still be used for editing. E.g. Edit > Cut Range.

So maybe as advanced loop has the 'precedence' on normal one just make the whole range (up to the end of the last segment) blue (or whatever colour is chosen): i.e. have a visual clue on the ruler of what is actually being looped?

Then we will have to disable the range menu items which limits what one can do while in this mode and could lead to confusion. My approach was for Advanced Looping to always show the range regardless of on/off/all loop status. This makes it easier to use the edit range features.

There is also now an ambiguity about what the loop button in the transport does when Advanced loop is on in preferences: at the moment it seems it still only switches normal loop on / off.

Exactly. That was the plan. Though it probably wouldn't be too hard to add "all" into the rotation.

About the latter I think now we have two possible loop modes from a UX point of view the best would be to have two distinct buttons in the main toolbar (within the transport controls is usually rather idiomatic for sequencers) and two distinct keyboard shortcuts to toggle these on/off. I think it's fine for one to have 'precedence' on the other but which is active should always be evident.

That's another option. I see it as one button with three states (like VLC media player does). But it can certainly be two buttons.

I hope this helps and is clear let me know if you want maybe a walk-through and more detailed explanation of the above.

Quite clear. Just that one thing I mentioned above (right-click and shift+left-click are the same) I wasn't sure about.


Rosegarden-user mailing list
Rosegarden-user@lists.sourceforge.net - use the link below to unsubscribe

Reply via email to