Kristian's response:

--- Begin Message ---
Sorry, here the explanations. 

there is no setter for the trustStorePassword, so I included it along
with javadocs.

the second one is just a typo, where the keyStorePassword is checked on
null, this check must be on the trustStorePassword, since we are in the
getTrustStorePassword-method.

best wishes 
Kristian


Daniel Rall wrote:
> 
> Please include a description of why this change is necessary, both so
> that someone will take the time to look at and so that we have
> something to use for the commit log.  See
> <http://jakarta.apache.org/site/source.html> for more info.
> 
>                              Thanks, Dan
> 
> [EMAIL PROTECTED] writes:
> 
> > *** /tmp/SecurityTool.java    Mi Feb  6 08:44:32 2002
> > --- /tmp/SecurityTool.java1735hPt     Mi Feb  6 08:44:32 2002
> > ***************
> > *** 428,437 ****
> >       }
> >
> >       /**
> > !      * Get the key store password.
> >        *
> > !      * @return String key store password.
> >        */
> >       public static String getTrustStorePassword()
> >       {
> >           if (System.getProperty(TRUST_STORE_PASSWORD) != null)
> > --- 428,447 ----
> >       }
> >
> >       /**
> > !      * Set the trust store password.
> >        *
> > !      * @param String  trust store password.
> >        */
> > +     public static void setTrustStorePassword(String x)
> > +     {
> > +         trustStorePassword = x;
> > +     }
> > +
> > +     /**
> > +      * Get the trust store password.
> > +      *
> > +      * @return String trust store password.
> > +      */
> >       public static String getTrustStorePassword()
> >       {
> >           if (System.getProperty(TRUST_STORE_PASSWORD) != null)
> > ***************
> > *** 438,444 ****
> >           {
> >               return System.getProperty(TRUST_STORE_PASSWORD);
> >           }
> > !         if (keyStorePassword == null)
> >           {
> >               return DEFAULT_TRUST_STORE_PASSWORD;
> >           }
> > --- 448,454 ----
> >           {
> >               return System.getProperty(TRUST_STORE_PASSWORD);
> >           }
> > !         if (trustStorePassword == null)
> >           {
> >               return DEFAULT_TRUST_STORE_PASSWORD;
> >           }

--- End Message ---

Reply via email to