Around 16:42 on Sep 27, 2002, Daniel Rall said: # Dustin, would you comment on that issue listed above? Your patch came # through as changing the entire Base64.java file, rather than just a # small section of code.
Yeah, I just needed to get it running, so I didn't try to fix what was there (well, I did, but I didn't spend a lot of time in it). Instead, I replaced it with one I'd written that I knew works. I ran into the problem when adding XML-RPC support to an application I've written (in java) that moves photographs around, and then creating a standalone app (in python) to talk to it. The data size was not the same upon decoding as it was before sending it up. With the changes I've made, it seems to work very well. I now have clients written in python (xmlrpclib), java (using this framework), perl (I didn't write the perl one, but it works), and objective C (using a framework built upon xmlrpc-c) all working with the application now. The issue is the handling of non-base64 data in the input of the decoder. The base64 decoder attempts to decode every character in the input stream. The one I provided skips characters that are not base64 characters. A third behavior is probably more appropriate: skip only whitespace characters and throw an exception on non-whitespace, non-base64 characters. I hope that's clear, it's Friday. :) -- SPY My girlfriend asked me which one I like better. pub 1024/3CAE01D5 1994/11/03 Dustin Sallings <[EMAIL PROTECTED]> | Key fingerprint = 87 02 57 08 02 D0 DA D6 C8 0F 3E 65 51 98 D8 BE L_______________________ I hope the answer won't upset her. ____________