Hello John Yes, you are right with the trim() issue in StartupHelper. I have fixed it and published the new version.
In my project, I need the Log4J implementation for the server process to log the handled request. On the client side the logger capability is not needed at all. For the matter of the JDK 1.1 compatibility I share the opinion to keep it for the client code. The server should implement the best afford for JDK 1.2 instead. Specially if used for SSL connections (eg. java.security.KeyStore). OFF-TOPIC: Why are you using MinML 1.6 in XML-RPC instead of the current version (MinML 1.7)? I also realized that MinML.setDocumentHandler(org.xml.sax.DocumentHandler) does not set the Locator for the passed DocumentHandler. This behavior throws a NullPointerExceptions when the Locator is referenced in StartupHelper. Is this an issue to be fixed? I would like to thank you all for the great work on the Apache XML-RPC project, which helps me to implement a flexible distributed management system. Mauro Canal [EMAIL PROTECTED] ---------------------------------------------------------------------- canal systems GmbH http://canalsystems.net Kreuzlingerstrasse 132 CH-8587 Oberaach Tel. +41-71 411 10 80 > -----Original Message----- > From: John Wilson [mailto:tug@;wilson.co.uk] > Sent: Monday, November 11, 2002 11:25 AM > To: [EMAIL PROTECTED] > Cc: [EMAIL PROTECTED] > Subject: Re: REPOST: https > > > > ----- Original Message ----- > From: "Mauro Canal" <[EMAIL PROTECTED]> > To: <[EMAIL PROTECTED]> > Sent: Monday, November 11, 2002 9:47 AM > Subject: REPOST: https > > > > Hi > > > > I recently implemented an easy to use start up functionality (including > SSL) > > for the Apache XML-RPC package. > > > > Configuration of the build in servers (WebServer and > SecureWebServer) and > > assosciated handlers is done in a XML file (conf/server.xml). > > > > I put all together on http://canalsystems.net/xml-rpc/index.html > > Mauro, > > I have taken a very quick look at the source. In StartupHelper on line > 720 you have: > > public void characters(char[] buf, int start, int length) throws > SAXParseException { > String s = new String(buf, start, length).trim(); > currentValue.append(s); > } > > A SAX parser is allowed to make multiple calls to characters > (e.g. it could > make one call per character). So the trim() call will produce a > result which > can differ between parsers. It's better to accumulate the > characters in the > StringBuffer and call trim in the end element callback. > > From a XML-RPC project point of view this code adds dependencies to Log4J > and JDK 1.2 or better. We have discussed moving from JDK 1.1 on this list > before in when we looked at moving from Hashtable to HashMap and there was > strong objection from some of the user community (applet and J2ME users). > > > Logging is an interesting issue - I think we should chew it over > on rpc-dev > before adopting a standard solution. > > I have cross posted this reply to rpc-dev as the JDK 1.2 and Log4J > discussion is probably better conducted there. > > John Wilson > The Wilson Partnership > http://www.wilson.co.uk > >
