Jochen Wiedmann wrote:
Daniel L. Rall wrote:
- return base64Codec.decode(cdata.getBytes()); + return base64Codec.decode((Object) cdata.getBytes());
This cast looks unnecessary. What's the thinking here?
No, it's required, because the compiler would pick the old method otherwise.
Why is that a problem? I was under the impression that this patch was to make XML-RPC work across different versions of Commons Codec. Do these Codec methods have different implementations with wildly different semantics?
I read Ryan Bloom's original description from "06/15/2004 10:01 AM", and examined the source code for Commons Codec. It's clear now, and I'm committing the patch.
Codec's EncoderException should be an unchecked exception (e.g. RuntimeException). Otherwise, it's Encoder/Decoder interfaces rather get in the way. Bleh.
