On Wed, Apr 07, 2010 at 09:22:06PM +0200, Leo Smiers wrote: > Reading/writing of the rpc.cfg network settings in the revision 43cac3700149 > has some bugs (I think it is introduced in revision d2d7dbb9b08b) > > file rpcemu.c > > line 461 should use 'network_type' iso 'networktype', eg: > set_config_string(NULL, "network_type", s);
Thanks for this. > lines 388-391 should make a copy of the strings. eg: > config.username = strdup(get_config_string(NULL, "username", NULL)); > config.ipaddress = strdup(get_config_string(NULL, "ipaddress", NULL)); > config.macaddress = strdup(get_config_string(NULL, "macaddress", NULL)); > config.bridgename = strdup(get_config_string(NULL, "bridgename", NULL)); Having had a look at the allegro library, it shouldn't be needed (it's returning pointers from allocated space that should stick around). However as I'm working on code to allow them to be changed whilst the program is running, taking a copy makes a lot more sense anyway. Should be checked in shortly. Peter -- Peter Howkins [email protected] _______________________________________________ Rpcemu mailing list [email protected] http://www.riscos.info/cgi-bin/mailman/listinfo/rpcemu
