On Fri, 2016-10-21 at 12:33 +0300, Panu Matilainen wrote: > On 10/21/2016 12:09 PM, Thierry Vignaud wrote: > > On 21 October 2016 at 08:51, Panu Matilainen <pmati...@redhat.com> wrote: > > > >>>> Please test and report any anomalies. From rc2 to final only regression > >>>> fixes will be allowed. Unless of course something really strange comes > >>>> up, you never know. Or I forgot something absolutely vital. THAT would > >>>> not count as a strange incident though. > >>> > >>> > >>> Humm.... Testsuite won't pass.... > >>> 2 tests are failing because of missing files... > >>> Please apply the attached patch > >>> It fixes: > >>> 84: rpmbuild debuginfo dwz FAILED > >>> (rpmbuild.at:396) > >>> 86: rpmbuild implicit suid binary FAILED > >>> (rpmbuild.at:509) > >> > >> > >> Ah, I did run the test-suite but not from the created tarball. One more > >> thing to remember when cutting releases. Or rather *cough* to document > >> *cough*.
In theory make distcheck should take care of that (I haven't actually tried if rpm is make distcheck clean though). > >> Applied (with a slightly expanded comments). > > > > If you could cherry-pick in rpm-4.13.x branch too, that would be nice :-) > > I will, eventually. Lets see what other things turn up first. Sorry for missing adding the new files to Makefile.am when adding those new tests. > >>> After that, 2 unexpected failures remain: > >>> > >>> 85: rpmbuild debuginfo dwz gnu_debuglink crc FAILED > >>> (rpmbuild.at:468) > >> > >> > >> ...but this I had just missed. It appears to be cured by commit > >> cherry-picking commit 3929ce4d58ab18c810b9a776f5c49d56cb436026. > > > > This commit doen't exist in git > > The attached patch fixes it anyway > > Sorry, should've been 41c4dcf507e2208585d6dc0952f59686a3a69d69, which > commit 4ec7c396fb9464a3fcff006408871f8175ab169b apparently depends on. Yes, that commit is necessary to make sure that tests don't need to run under fakechroot to pass. I had much trouble with fakechroot and so wanted to avoid adding more tests that depended on it. It also helps if you want to install rpm under some other path than /usr/lib/rpm. Cheers, mark _______________________________________________ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
