@soig you're making a good point, if one wanna look at truly stupid mechanisms,
one should look at how the internal dependency generator is doing the same work
over and over and over.. It's now become what takes up the most time of build
for certain packages..
In contrast, running 'find' over and over within a buildroot with caches
enabled and all, the amount of work being repeated is neglible, just as the
time it takes to run the scripts.
The scripts are written in a similar fashion as the existing ones in place,
where limiting the amount of times 'find' being run really hasn't been of much
relevance, these are simple shell scripts.
Refactoring of the scripts really aren't all that worthwhile spending time on,
especially not compared to the gain of the functionality provided by.
For health reasons, I'm only sporadically active, so it's certainly not
something worthwhile spending my time on at least.
Same for script names, does it matter all that much?
The names comes from the mandriva spec-helper package, where they originate
from.
If not clear enough, it sounds more sensible to just document it's behaviour in
the scripts themself anyways..
If the the scripts and functionality of the scripts are sensible enough, I
recommend just applying whatever cosmetics on top of my pull request as-is, I'm
rather absent these days.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/122#issuecomment-288787934
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
