Eh. It can cause a bit of awkwardness or need for discussion when you get
unlucky, agreed. So far I'm not very keen to send 3+ different PRs for small
fixes to cleanup when they don't depend on each other.
I appreciate the attention to detail. Cleanup fixes can be fiddly to get right
even if there isn't a concern with the API. Perhaps one argument for a topic
PR that gets you in the right mood for nitpicking :).
What a fun commit "avoid double free ... assume that the object has been freed
if it is not
on the list." Good luck :).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/359#issuecomment-368819363
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint