Conan-Kudo requested changes on this pull request.

NAK. These changes are unnecessarily harmful.

The first change makes the assumption that static link libraries don't exist in 
a distribution, and that they would be considered functionally useless. On top 
of it, without the private requires, certain linking situations actually break 
with more poorly designed dynamic link libraries (e.g. libraries that aren't 
properly opaque in their interfaces and leak in API requirements from 
dependencies).

The second change is just dumb, because the pkgconfig implementation is 
necessary for even using it, and ensures that build scripts that implicitly 
expect pkgconfig to be available for querying the file will work.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/411#pullrequestreview-102893496
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Reply via email to