Back from vacation...
This (using /proc/self/fd when available) was what I had in mind, so we're on
the right track here, thanks for the work so far. Some quick remarks ==
requests:
- rpm comment style is "/* foo */", "// foo" should not be used
- just slap the new cloexec function to end of rpmio/rpmio.c (it's quite well
at home there, rpmio.c has all/most headers already and this really doesn't
need a separate file) and put the prototype to rpmio_internal.h, this is not an
interface we want to export
- the jump to fallback label seems klunky and unnecessary, just handle the
respective cases in the if-else directly
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/444#issuecomment-392494507
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
