> No objection to adding LDFLAGS to %configure, it's actually long overdue.
> Fedora has had its own version of this for a quite some time now, but nobody
> got around to upstreaming it. This seems like as good time as any to take a
> look at that and consider which parts would be upstreamable.
Would you be fine with this pull request as is?
>
> There are a whole bunch of related things done, mostly done in
> redhat-rpm-config. For details, see
> https://src.fedoraproject.org/rpms/redhat-rpm-config/blob/master/f/macros#_27
> but in summary:
>
> * %optflags is only a building block for language specific %build_fooflags
> macros (except for ldflags which is not related)
> * the %build_fooflags macros are used for setting the environment
> * the environment setting is separated from %configure so it's usable for
> other make systems too
> * there are further %extension_fooflags macros which are meant for building
> things like perl and python C-extensions
>
> In addition, %build_ldflags is passed as RPM_LD_FLAGS to all the build
> scripts via %___build_pre, but that's an older addition than the
> redhat-rpm-config stuff above so not sure how relevant/useful it is in
> reality.
I'm CCing SUSE related people how are much more skilled with that: @scarabeusiv
@DimStar77 @mlschroe
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/660#issuecomment-486575591
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
