pmatilai commented on this pull request.
> +
+ if (!spec->buildrequires) {
+ rc = RPMRC_OK;
+ goto exit;
+ }
+
+ if ((rc = doScript(spec, RPMBUILD_BUILDREQUIRES, "%generate_buildrequires",
+ getStringBuf(spec->buildrequires), &sb_stdout, test)))
+ goto exit;
+
+ /* add results to requires of the srpm */
+ argvSplit(&output, getStringBuf(sb_stdout), "\n\r");
+ outc = argvCount(output);
+
+ if (!outc) {
+ rc = RPMRC_OK;
This is assignment is redundant, rc is already ok if we get this far.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/593#pullrequestreview-235951890_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
